Skip to content

CI: Added ecosystem check#574

Merged
Boshen merged 21 commits into
oxc-project:mainfrom
Leonard-Yeung:main
Jul 21, 2023
Merged

CI: Added ecosystem check#574
Boshen merged 21 commits into
oxc-project:mainfrom
Leonard-Yeung:main

Conversation

@Leonard-Yeung
Copy link
Copy Markdown
Contributor

@Leonard-Yeung Leonard-Yeung commented Jul 19, 2023

For issue #511
I have added an extra job to the existing Github Actions to ensure oxclint won't break real codebase.
The new job will clone microsoft/vscode, build oxlint under target/debug/oxclint, and run oxlint against the vsCode repo.

Copy link
Copy Markdown
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me fix no-this-alias on main.

Comment thread .rustc_info.json Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
@Boshen
Copy link
Copy Markdown
Member

Boshen commented Jul 20, 2023

You may rebase from the main branch, I fixed the severity on no-this-alias.

@github-actions github-actions Bot added the A-linter Area - Linter label Jul 20, 2023
@github-actions github-actions Bot removed the A-linter Area - Linter label Jul 20, 2023
@Leonard-Yeung Leonard-Yeung marked this pull request as ready for review July 20, 2023 23:45
Copy link
Copy Markdown
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's test this out and improve upon it. Thank you!

@Boshen Boshen merged commit 73338cb into oxc-project:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants