Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

  • Update dependency @rspack/core to ~1.7.1
  • Unpin the version as Rspack 1.x is stable enough.

Related

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings January 6, 2026 08:49
@netlify
Copy link

netlify bot commented Jan 6, 2026

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 26b84cd
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/695cce3326b12a0008a42c60
😎 Deploy Preview https://deploy-preview-6904--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 67 (🟢 up 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@gemini-code-assist
Copy link

Summary of Changes

Hello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a routine dependency update, specifically upgrading @rspack/core to its ~1.7.1 version. This change also involves adjusting the versioning strategy from a pinned exact version to a more flexible tilde-prefixed version, signaling increased confidence in the stability of the Rspack 1.x series. The update propagates through the project's lockfile, ensuring all dependent packages correctly reference the new Rspack core version.

Highlights

  • Dependency Update: The @rspack/core dependency has been updated to version ~1.7.1.
  • Version Unpinning: The exact version of @rspack/core has been unpinned, now using a tilde (~) prefix, reflecting that Rspack 1.x is considered stable enough for broader version compatibility.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @rspack/core dependency from a pinned version 1.7.0 to ~1.7.1, and updates the lockfile accordingly. This is a good move to allow patch updates. I have one suggestion regarding the version range to better align with the stated intent of trusting Rspack's 1.x stability.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the @rspack/core dependency from the pinned version 1.7.0 to the tilde range ~1.7.1, allowing automatic patch-level updates (e.g., 1.7.2, 1.7.3) while preventing minor version updates. This change reflects increased confidence in Rspack 1.x stability.

Key Changes:

  • Updated version specifier from exact 1.7.0 to tilde range ~1.7.1 in packages/core/package.json
  • Lockfile updated to resolve to version 1.7.1 with all platform-specific bindings
  • All transitive dependencies updated to reference the new version

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
packages/core/package.json Updated @rspack/core dependency specifier from 1.7.0 to ~1.7.1, allowing patch updates
pnpm-lock.yaml Comprehensive lockfile update adding 1.7.1 package definitions, platform-specific bindings for all architectures, and updating all dependency resolution entries to reference the new version
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit b410292 into v1.x Jan 6, 2026
10 checks passed
@chenjiahan chenjiahan deleted the update_rspack_0106 branch January 6, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants