After updating ESLint and TypeScript, rslib isn't including type definitions anymore

[binarykitchen]

In my videomail-client library, in this commit, I've migrated TS and ESLint, along with few other changes, but now other consumer projects cannot import the types anymore.

Context: all source code with their types are put in the root src folder.

So, for package.json I had to correct paths, from

  "exports": {
    ".": {
      "types": "./dist/esm/index.d.ts", // <----- OLD: no src folder
      "umd": "./dist/umd/index.js",
      "require": "./dist/cjs/index.cjs",
      "import": "./dist/esm/index.js"
    }
  },
  "main": "./dist/esm/index.js",
  "module": "./dist/esm/index.js",
  "types": "./dist/esm/index.d.ts", // <----- OLD: no src folder
  "files": [
    "dist"
  ],

to

  "exports": {
    ".": {
      "types": "./dist/esm/src/index.d.ts", // <----- NEW: with src folder
      "umd": "./dist/umd/index.js",
      "require": "./dist/cjs/index.cjs",
      "import": "./dist/esm/index.js"
    }
  },
  "main": "./dist/esm/index.js",
  "module": "./dist/esm/index.js",
  "types": "./dist/esm/src/index.d.ts",  // <----- NEW: with src folder
  "files": [
    "dist"
  ],

Then it worked.

To me, it feels weird. Because all is put in the src folder. When exporting, it's a different context where src doesn't have to be mentioned, but it matters.

Or am I missing something?

[Timeless0911]

You should specify rootDir to src, which has a breaking change in TypeScript 6.

[Timeless0911]

This may be a migration step when you update Typescript v6 and maybe there are other changes need to be migrated, more details see TS blog above.

[binarykitchen]

You should specify rootDir to src, which has a breaking change in TypeScript 6.

Well, I've got plenty of other utils/libraries written in TypeScript, but not involved in the build. For example, Storybook in another folder, using TypeScript as well.

For example, Storybook Main in TS. It should remain included in the TS config along with the source code when it comes to TypeScript standards, rules and definitions.

If you set rootDir to src then those errors come up and plenty more.

We should be capable to define TypeScript standards from the root folder, but only export types from the source folder. How??

[Timeless0911]

Usually in this scenario, users may use two TS config files: one is tsconfig.json, and the other is tsconfig.build.json.
The outer tsconfig.json can include all files for type checking, while tsconfig.build.json is used by builders or bundlers to generate type files for users.

[Timeless0911]

tsconfig.build.json can inherit from the base TS config, then make distinctions on key configuration items such as include and rootDir.

[binarykitchen]

Got it. Fixed:
https://github.com/binarykitchen/videomail-client/blob/master/tsconfig.build.json

which inherits from:
https://github.com/binarykitchen/videomail-client/blob/master/tsconfig.json

Thank you very much, your support is timeless ;)