fix(create-rslib): compatible with Storybook 10 #1310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the createRequire import and setup to enable the use of require.resolve() in ES module-based Storybook configuration files. This is necessary for the getAbsolutePath function to resolve package paths in environments like Yarn PnP or monorepos.
- Adds
createRequireimport fromnode:module - Creates a
requirefunction usingcreateRequire(import.meta.url)
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| template-[vue]-[storybook]-ts/.storybook/main.ts | Adds createRequire setup for Vue+Storybook TypeScript template |
| template-[vue]-[storybook]-js/.storybook/main.js | Adds createRequire setup for Vue+Storybook JavaScript template |
| template-[vue]-[storybook,vitest]-ts/.storybook/main.ts | Adds createRequire setup for Vue+Storybook+Vitest TypeScript template |
| template-[vue]-[storybook,vitest]-js/.storybook/main.js | Adds createRequire setup for Vue+Storybook+Vitest JavaScript template |
| template-[vue]-[rstest,storybook]-ts/.storybook/main.ts | Adds createRequire setup for Vue+rstest+Storybook TypeScript template |
| template-[vue]-[rstest,storybook]-js/.storybook/main.js | Adds createRequire setup for Vue+rstest+Storybook JavaScript template |
| template-[react]-[storybook]-ts/.storybook/main.ts | Adds createRequire setup for React+Storybook TypeScript template |
| template-[react]-[storybook]-js/.storybook/main.js | Adds createRequire setup for React+Storybook JavaScript template |
| template-[react]-[storybook,vitest]-ts/.storybook/main.ts | Adds createRequire setup for React+Storybook+Vitest TypeScript template |
| template-[react]-[storybook,vitest]-js/.storybook/main.js | Adds createRequire setup for React+Storybook+Vitest JavaScript template |
| template-[react]-[rstest,storybook]-ts/.storybook/main.ts | Adds createRequire setup for React+rstest+Storybook TypeScript template |
| template-[react]-[rstest,storybook]-js/.storybook/main.js | Adds createRequire setup for React+rstest+Storybook JavaScript template |
| fragments/tools/storybook-vue-ts/.storybook/main.ts | Adds createRequire setup for Vue+Storybook TypeScript fragment |
| fragments/tools/storybook-vue-js/.storybook/main.js | Adds createRequire setup for Vue+Storybook JavaScript fragment |
| fragments/tools/storybook-react-ts/.storybook/main.ts | Adds createRequire setup for React+Storybook TypeScript fragment |
| fragments/tools/storybook-react-js/.storybook/main.js | Adds createRequire setup for React+Storybook JavaScript fragment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/create-rslib/template-[vue]-[storybook,vitest]-js/.storybook/main.js
Show resolved
Hide resolved
packages/create-rslib/template-[vue]-[rstest,storybook]-js/.storybook/main.js
Show resolved
Hide resolved
packages/create-rslib/template-[react]-[storybook]-js/.storybook/main.js
Show resolved
Hide resolved
packages/create-rslib/template-[react]-[storybook,vitest]-js/.storybook/main.js
Show resolved
Hide resolved
packages/create-rslib/template-[react]-[rstest,storybook]-js/.storybook/main.js
Show resolved
Hide resolved
packages/create-rslib/fragments/tools/storybook-vue-js/.storybook/main.js
Show resolved
Hide resolved
packages/create-rslib/fragments/tools/storybook-react-js/.storybook/main.js
Show resolved
Hide resolved
Timeless0911
approved these changes
Nov 3, 2025
Contributor
Timeless0911
left a comment
Timeless0911
left a comment
There was a problem hiding this comment.
should also compatible in https://github.com/rspack-contrib/rstack-examples/tree/main/rslib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
due to the breaking change of https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#from-version-9x-to-1000. use pure ESM syntax in Storybook config files.
Related Links
Checklist