fix: verbose Rslib normalized config only in Rslib debug mode #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability to conditionally print the serialized Rslib configuration only when the DEBUG=rslib environment variable is set. Previously, the debug logs were always printed when debug logging was enabled.
Key changes:
- Introduces a new
shouldPrintSerializedRslibConfig()function to check if theDEBUGenvironment variable containsrslib - Conditionally prints the serialized Rslib config based on this check
- Updates documentation in both English and Chinese to inform users about the new
DEBUG=rsliboption
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/cli/initConfig.ts | Adds shouldPrintSerializedRslibConfig() function and wraps config debug logging with a conditional check |
| website/docs/en/guide/basic/configure-rslib.mdx | Updates English documentation to mention the DEBUG=rslib environment variable option |
| website/docs/zh/guide/basic/configure-rslib.mdx | Updates Chinese documentation to mention the DEBUG=rslib environment variable option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fi3ework
previously approved these changes
Nov 3, 2025
fi3ework
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Only debug serialized rslib config when
DEBUG=rslibin debug mode since users do not need to get normalized Rslib configuration in common.Related Links
Checklist