fix: remove externalsPresets.node #1318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds externalsPresets: { node: false } configuration to the Rspack configuration when targeting Node.js environments. This prevents Rspack from automatically treating Node.js built-in modules as externals, allowing explicit control through the nodeBuiltInModules array defined in the externalsConfig.
- Added
externalsPresets.node: falseto Node target configuration incomposeTargetConfigfunction - Updated test snapshots to reflect the new configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/config.ts | Added externalsPresets: { node: false } to the rspack configuration for Node.js target |
| packages/core/tests/snapshots/config.test.ts.snap | Updated test snapshots to include the new externalsPresets configuration in all Node.js target scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Timeless0911
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
remove
externalsPresets.node, in Rslib, we already using a hand made module builtin modules list. so it's duplicsated.in the other hand,
externals: { fs: false }can't bail out externalize ifexternalsPresetsexist as it's implemented by another ExternalPlugin.Related Links
Checklist