feat: runtime chunk name default to rslib-runtime
#1320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the runtime chunk naming in experimental ESM output from the default 'single' to a custom name 'rslib-runtime'. This change provides a more descriptive and library-specific name for the runtime chunk file.
Key changes:
- Modified the runtime chunk configuration to use an object with a custom name instead of the string
'single' - Updated test snapshots to reflect the new runtime filename from
runtime.jstorslib-runtime.js
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/config.ts | Changed runtimeChunk from 'single' to an object with name: 'rslib-runtime' for experimental ESM output |
| packages/core/tests/snapshots/config.test.ts.snap | Updated snapshot to reflect the new runtime chunk configuration object |
| tests/integration/vue/index.test.ts | Updated test expectations to reference rslib-runtime.js instead of runtime.js |
| tests/integration/style/css-modules-named/index.test.ts | Updated test expectations to reference rslib-runtime.js instead of runtime.js |
| tests/integration/resolve/index.test.ts | Updated test expectations to reference rslib-runtime.js instead of runtime.js |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chenjiahan
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Runtime chunk name default to
rslib-runtimein advanced esm to avoid name conflict.Related Links
Checklist