fix: emit correct warning message when no entry found in bundleless mode #1359
+34
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Copilot finished reviewing on behalf of
Timeless0911
November 21, 2025 10:25
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the error message displayed when no entry files are found in bundleless mode. Previously, the error message showed Cannot find [object Array], which was uninformative. The new error message clearly lists the file patterns that couldn't be matched and provides guidance on how to fix the issue.
- Improved error message to show actual file patterns instead of
[object Array] - Added test coverage for both bundle and bundleless modes when entry files don't exist
- Error stack is cleared for cleaner console output
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/config.ts | Updated error message to display the actual entry file patterns with helpful guidance when no files are found in bundleless mode |
| tests/integration/entry/validate/bundleNonExistingFile.config.ts | Added test configuration for bundle mode with non-existing entry file |
| tests/integration/entry/validate/bundlelessNonExistingFile.config.ts | Added test configuration for bundleless mode with non-existing entry files |
| tests/integration/entry/index.test.ts | Expanded test to validate error messages for both bundle and bundleless modes with non-existing files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fi3ework
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before
After
Related Links
Checklist