Skip to content

fix: clean declaration maps before the build starts #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2025
Merged

fix: clean declaration maps before the build starts #1363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/plugin-dts/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export const pluginDts = (options: PluginDtsOptions = {}): RsbuildPlugin => ({
warnIfOutside(cwd, declarationDir, 'declarationDir');
warnIfOutside(cwd, outDir, 'outDir');

// clean dts files
// clean dts files and maps
if (config.output.cleanDistPath !== false) {
await cleanDtsFiles(dtsEmitPath);
}
Expand Down
9 changes: 8 additions & 1 deletion packages/plugin-dts/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,14 @@ export const globDtsFiles = async (
};

export async function cleanDtsFiles(dir: string): Promise<void> {
const patterns = ['/**/*.d.ts', '/**/*.d.cts', '/**/*.d.mts'];
const patterns = [
'/**/*.d.ts',
'/**/*.d.cts',
'/**/*.d.mts',
'/**/*.d.ts.map',
'/**/*.d.cts.map',
'/**/*.d.mts.map',
];
const allFiles = await globDtsFiles(dir, patterns);

await Promise.all(
Expand Down
12 changes: 11 additions & 1 deletion tests/scripts/shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,14 +465,24 @@ export async function createTempFiles(
const tempDirEsm = join(fixturePath, 'dist-types', 'esm');
const tempFileCjs = join(tempDirCjs, 'tempFile.d.ts');
const tempFileEsm = join(tempDirEsm, 'tempFile.d.ts');
const tempFileMapCjs = join(tempDirCjs, 'tempFile.d.ts.map');
const tempFileMapEsm = join(tempDirEsm, 'tempFile.d.ts.map');

await fs.promises.mkdir(tempDirCjs, { recursive: true });
await fs.promises.mkdir(tempDirEsm, { recursive: true });

await fs.promises.writeFile(tempFileCjs, 'console.log("temp file for cjs");');
await fs.promises.writeFile(tempFileEsm, 'console.log("temp file for esm");');
await fs.promises.writeFile(
tempFileMapCjs,
'console.log("temp map file for cjs");',
);
await fs.promises.writeFile(
tempFileMapEsm,
'console.log("temp map file for esm");',
);

checkFile.push(tempFileCjs, tempFileEsm);
checkFile.push(tempFileCjs, tempFileEsm, tempFileMapCjs, tempFileMapEsm);

if (bundle) {
const tempDirRslib = join(fixturePath, '.rslib', 'declarations', 'cjs');
Expand Down
Loading