-
-
Notifications
You must be signed in to change notification settings - Fork 755
feat!: introduce lazy compilation middleware #9515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
CodSpeed Performance ReportMerging #9515 will not alter performanceComparing Summary
|
e1a6132 to
14c4bf9
Compare
etripier
reviewed
Mar 4, 2025
packages/rspack/src/builtin-plugin/lazy-compilation/middleware.ts
Outdated
Show resolved
Hide resolved
ae3ff58 to
19edf61
Compare
df3bad4 to
2a44846
Compare
4071a13 to
ae343e3
Compare
chenjiahan
reviewed
Mar 23, 2025
packages/rspack/src/builtin-plugin/lazy-compilation/middleware.ts
Outdated
Show resolved
Hide resolved
chenjiahan
reviewed
Mar 23, 2025
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
b1aabb5 to
ff6e61e
Compare
ff6e61e to
6ad32ee
Compare
SyMind
approved these changes
Mar 25, 2025
SyMind
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: feature
release: feature related release(mr only)
team
The issue/pr is created by the member of Rspack.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce LazyCompilationMiddleware, which is used to support handle requests sent by lazy-compilation.
Breaking change
There is no extra server for LazyCompilation, extra server has following issues:
In order to solve above issues, we move the logic inside previous lazy compilation server backend to a standalong middleware which can be used by any custom server.
eg.
Even if your server does not support express style middleware, you can create a simple wrapper yourself, just to make sure you satisfy its interface
Checklist