Skip to content

Conversation

@1714080902120
Copy link
Contributor

Summary

I have a custom plugin that needs to add some code to the runtime, and during the migration process I find that the code replaced fail, and after debugging, I find that the code should have been replaced:

chunkLoadingGlobal.push = webpackJsonpCallback.bind(null, chunkLoadingGlobal.push.bind(chunkLoadingGlobal));

It becomes as follows:

chunkLoadingGlobal.push = webpackJsonpCallback.bind( null,   chunkLoadingGlobal.push.bind(chunkLoadingGlobal));

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Mar 19, 2025
@netlify
Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit bd3e1c2
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67e51da040733e000867cec4

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 19, 2025

CodSpeed Performance Report

Merging #9737 will not alter performance

Comparing 1714080902120:jsonp_chunk_loading_with_callback_format (3d1d458) with main (e5f16e2)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 8 untouched benchmarks

@GiveMe-A-Name
Copy link
Member

You need update test snapshot.
cd packages/rspack-test-tools and run npm run testu

@GiveMe-A-Name
Copy link
Member

There have some snapshot was not updated.
You can cd tests/webpack-test, then run pnpm run testu to update snapshots

@1714080902120
Copy link
Contributor Author

Well, it looks like I can see how to run based on a failed CI build.

@1714080902120 1714080902120 force-pushed the jsonp_chunk_loading_with_callback_format branch from 3d1d458 to bd3e1c2 Compare March 27, 2025 09:42
@1714080902120 1714080902120 deleted the jsonp_chunk_loading_with_callback_format branch March 27, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants