Skip to content

feat: support experiments build http #9741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahabhgk merged 43 commits into from
Mar 25, 2025
Merged

feat: support experiments build http #9741

ahabhgk merged 43 commits into from
Mar 25, 2025

Conversation

@ScriptedAlchemy
Copy link
Contributor

@ScriptedAlchemy ScriptedAlchemy commented Mar 20, 2025 •
edited
Loading

Summary

Add buildHttp experiment bindings for rust plugin

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Mar 20, 2025
@netlify
Copy link

netlify bot commented Mar 20, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 481d411
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67e2b26551925800084c47c8

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 20, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9741 will not alter performance

Comparing build-http-js (481d411) with main (55d5d81)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 8 untouched benchmarks

@ScriptedAlchemy ScriptedAlchemy marked this pull request as ready for review March 23, 2025 03:08
@ScriptedAlchemy ScriptedAlchemy requested a review from ahabhgk March 23, 2025 03:08
ahabhgk
ahabhgk reviewed Mar 25, 2025
View reviewed changes
crates/rspack_plugin_schemes/src/http_cache.rs
if status == 304 {
if let Some(cached) = cached_result {
let new_valid_until = valid_until.max(cached.meta.valid_until);
println!("GET {} [{}] (unchanged)", url, status);
Copy link
Contributor

@ahabhgk ahabhgk Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

println! can be replaced to logger, there is a get_logger on compilation

@ahabhgk
Copy link
Contributor

ahabhgk commented Mar 25, 2025

Let's merge it first, we can resolve the remaining things in the future PR since it's still experimental

@ahabhgk ahabhgk enabled auto-merge (squash) March 25, 2025 12:42
@ahabhgk ahabhgk changed the title feat: build http feat: support experiments build http Mar 25, 2025
@ahabhgk ahabhgk disabled auto-merge March 25, 2025 13:55
@ahabhgk ahabhgk enabled auto-merge (squash) March 25, 2025 13:55
@ahabhgk ahabhgk merged commit ed72d36 into main Mar 25, 2025
33 checks passed
@ahabhgk ahabhgk deleted the build-http-js branch March 25, 2025 14:04
@ScriptedAlchemy
Copy link
Contributor Author

ScriptedAlchemy commented Mar 25, 2025

Awesome. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ScriptedAlchemy @ahabhgk