Skip to content

fix: getModuleId should return number for deterministic moduleIds #9785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahabhgk merged 2 commits into from
Mar 25, 2025
Merged

fix: getModuleId should return number for deterministic moduleIds #9785

ahabhgk merged 2 commits into from
Mar 25, 2025

Conversation

@ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Mar 24, 2025

Summary

getModuleId should return number for deterministic moduleIds

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Mar 24, 2025
@netlify
Copy link

netlify bot commented Mar 24, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 8f8e990
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67e22c5744132500087be64c

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 24, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9785 will not alter performance

Comparing number-get-module-id (8f8e990) with main (8ab77ba)

Summary

✅ 8 untouched benchmarks

@ahabhgk ahabhgk enabled auto-merge (squash) March 25, 2025 04:12
@ahabhgk ahabhgk merged commit 9659d18 into main Mar 25, 2025
31 checks passed
@ahabhgk ahabhgk deleted the number-get-module-id branch March 25, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SyMind SyMind SyMind approved these changes

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahabhgk @SyMind