Require a dist file for every feature #1343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will mean that running just `npm run dist` will be enough even if the dist file doesn't exist yet.
captainbrosset
approved these changes
Jul 10, 2024
Contributor
captainbrosset
left a comment
captainbrosset
left a comment
There was a problem hiding this comment.
I've not looked at the implementation of the dist script before, so can't really judge the technical soundness of this, but if this makes it possible to run npm run dist without having to pass the feature file name with it, then great!!
Collaborator
Author
|
Thanks @captainbrosset! Hope you'll enjoy |
ddbeck
added a commit
to ddbeck/web-features
that referenced
this pull request
Aug 27, 2024
We erroneously stopped checking for this with web-platform-dx#1343
ddbeck
added a commit
that referenced
this pull request
Sep 2, 2024
We erroneously stopped checking for this with #1343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will mean that running just
npm run distwill be enough even ifthe dist file doesn't exist yet.