Skip to content

Conversation

@tropicadri
Copy link
Contributor

@tropicadri tropicadri commented Jul 24, 2024

Adds a workflow to run update-drafts one a week and create a PR with the updates.

I created a copy repo and let the workflow run to have an example of the PR it creates: tropicadri/ga-test#3

@tropicadri tropicadri marked this pull request as ready for review July 24, 2024 20:20
@tropicadri tropicadri requested a review from foolip July 24, 2024 20:22

on:
schedule:
# Runs at midnight on Mondays 05:30 UTC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's as good a time as any! I'll also add workflow_dispatch so that we can trigger this manually at any time. Often useful for ensuring everything works after a change to the script or workflow.

Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tropicadri! Let's land this and get spec drafts updating.

@foolip foolip merged commit 44307ae into web-platform-dx:main Jul 26, 2024
@foolip
Copy link
Collaborator

foolip commented Jul 26, 2024

@tropicadri looks like there's a problem. In https://github.com/web-platform-dx/web-features/actions/runs/10117116884/job/27981430193#step:7:92 the error is "GitHub Actions is not permitted to create or approve pull requests".

I haven't seen this before, but I guess we need to give it permissions...

@tropicadri
Copy link
Contributor Author

Ah yes, I enabled write permissions for the test repo that I created, but it seems the organization might also need to be configured to allow write pull requests, but it also needs to be a repo admin, so I couldn't set it up.

Go to https://github.com/organizations/web-platform-dx/settings/actions and check Allow GitHub Actions to create and approve pull requests
Then go to https://github.com/web-platform-dx/web-features/settings/actions and check the box that previously was grayed out

@foolip
Copy link
Collaborator

foolip commented Jul 30, 2024

@tropicadri do you know if #1517 might work, or if one also has to enable it in the GitHub settings? I don't have access to https://github.com/organizations/web-platform-dx/settings/actions, I'd need to ask W3C staff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants