-
Notifications
You must be signed in to change notification settings - Fork 199
Adding weekly run to update draft features by spec #1502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding weekly run to update draft features by spec #1502
Conversation
|
|
||
| on: | ||
| schedule: | ||
| # Runs at midnight on Mondays 05:30 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's as good a time as any! I'll also add workflow_dispatch so that we can trigger this manually at any time. Often useful for ensuring everything works after a change to the script or workflow.
foolip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tropicadri! Let's land this and get spec drafts updating.
|
@tropicadri looks like there's a problem. In https://github.com/web-platform-dx/web-features/actions/runs/10117116884/job/27981430193#step:7:92 the error is "GitHub Actions is not permitted to create or approve pull requests". I haven't seen this before, but I guess we need to give it permissions... |
|
Ah yes, I enabled write permissions for the test repo that I created, but it seems the organization might also need to be configured to allow write pull requests, but it also needs to be a repo admin, so I couldn't set it up. Go to https://github.com/organizations/web-platform-dx/settings/actions and check Allow GitHub Actions to create and approve pull requests |
|
@tropicadri do you know if #1517 might work, or if one also has to enable it in the GitHub settings? I don't have access to https://github.com/organizations/web-platform-dx/settings/actions, I'd need to ask W3C staff. |
Adds a workflow to run update-drafts one a week and create a PR with the updates.
I created a copy repo and let the workflow run to have an example of the PR it creates: tropicadri/ga-test#3