Skip to content

Give the draft updater workflow pull requests write permission #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2024
Merged

Give the draft updater workflow pull requests write permission #1517

merged 2 commits into from
Jul 30, 2024

Conversation

@foolip
Copy link
Collaborator

@foolip foolip commented Jul 26, 2024

No description provided.

@foolip foolip requested a review from tropicadri July 26, 2024 20:23
@foolip
Copy link
Collaborator Author

foolip commented Jul 26, 2024

@tropicadri I haven't tried this, but maybe it will work :)

@foolip foolip mentioned this pull request Jul 30, 2024
Merged
@tropicadri
Copy link
Contributor

tropicadri commented Jul 30, 2024

I am not 100% sure it will, work, but let's give it a try!

@foolip foolip merged commit 5ad5062 into main Jul 30, 2024
@foolip foolip deleted the github-actions-permissions branch July 30, 2024 19:20
@foolip
Copy link
Collaborator Author

foolip commented Jul 30, 2024

Unfortunately, it didn't work:
https://github.com/web-platform-dx/web-features/actions/runs/10168469504/job/28123129636#step:7:81

@dontcallmedom @tidoust can either of you help change the org settings following @tropicadri's instructions in #1502 (comment)?

@tidoust
Copy link
Member

tidoust commented Jul 30, 2024

@dontcallmedom @tidoust can either of you help change the org settings following @tropicadri's instructions in #1502 (comment)?

Sure! I just checked the "Allow GitHub Actions to create and approve pull requests" checkbox at the organization level. Other settings look good to me.

@foolip
Copy link
Collaborator Author

foolip commented Aug 9, 2024

Thank you @tidoust! It still doesn't work, but it's because of something else now that I'll debug.

foolip added a commit that referenced this pull request Aug 9, 2024
@foolip
Revert "Give the draft updater workflow pull requests write permission (
6418481 
#1517)"

This reverts commit 5ad5062.
@foolip foolip mentioned this pull request Aug 9, 2024
Merged
ddbeck pushed a commit that referenced this pull request Aug 9, 2024
@foolip
Revert "Give the draft updater workflow pull requests write permission (
09e182f 
#1517)" (#1568)

This reverts commit 5ad5062.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tropicadri tropicadri tropicadri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@foolip @tropicadri @tidoust