Update governance to allow peers to merge status changes #1553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddbeck
added
documentation
atopal
approved these changes
Aug 7, 2024
Collaborator
atopal
left a comment
atopal
left a comment
There was a problem hiding this comment.
Thank you Daniel. This looks good to me!
foolip
approved these changes
Aug 7, 2024
captainbrosset
approved these changes
Aug 13, 2024
Elchi3
approved these changes
Aug 15, 2024
petele
approved these changes
Aug 15, 2024
jgraham
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to modify the governance doc to reflect actual PR management practices, which have departed a little from what we initially proposed. Chiefly, this would allow peers to merge any feature change, with the exception of deleting a feature outright. I also made a few consistency edits along the way, to reflect the terminology we actually use.
Note: This is a governance change, so I'd like to have at least a few owners review and approve before merging (and block on any objections).
Fixes #1528.