Skip to content

Conversation

@Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Aug 26, 2024

This is a feature that is a sink for all the basic JavaScript language features for which I believe we don't want to create separate features. They are all "baseline highest" meaning that baseline_low_date is always 2015-07-29 and baseline_high_date is always 2018-01-29 (the earliest possible dates currently).

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Aug 26, 2024
@autonome
Copy link
Contributor

autonome commented Sep 2, 2024

A couple of questions / thoughts, none blocking:

  • "basics" sounds like a tutorial or learning material, maybe something in the direction of "core" would better reflect that the intent?

  • are you thinking prototype/functions as a separate feature? nm, saw the function PR

  • a few builtins i could imagine breaking out into a types feature

  • ditto for the addressing bits

Overall, +1 to the idea of a catchall for now though!

@Elchi3 Elchi3 changed the title Add JavaScript basics Add a "JavaScript core (initial support)" feature Sep 5, 2024
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. I would have prefered it even more if the support data matched the first versions of browsers. But I don't see a compelling reason to remove debugger and empty from this feature to achieve this.

@Elchi3 Elchi3 requested a review from ddbeck October 7, 2024 10:08
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for getting hung up on names and descriptions here, but being a sink, I think it's important that we make sure we understand what we're telling ourselves here. A few ideas for you.

@Elchi3
Copy link
Collaborator Author

Elchi3 commented Oct 7, 2024

Thanks Daniel, I agree we want to make sure this sink feature is well described. I like your suggestions and updated this PR accordingly.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I'm pretty happy with this, at least as a first pass (before we get composition and such). Thank you!

@ddbeck ddbeck merged commit 5316568 into web-platform-dx:main Oct 7, 2024
3 checks passed
@Elchi3 Elchi3 deleted the js-basics branch October 7, 2024 14:44
@jamesnw jamesnw mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants