-
Notifications
You must be signed in to change notification settings - Fork 199
Add a "JavaScript core (initial support)" feature #1670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A couple of questions / thoughts, none blocking:
Overall, +1 to the idea of a catchall for now though! |
captainbrosset
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. I would have prefered it even more if the support data matched the first versions of browsers. But I don't see a compelling reason to remove debugger and empty from this feature to achieve this.
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for getting hung up on names and descriptions here, but being a sink, I think it's important that we make sure we understand what we're telling ourselves here. A few ideas for you.
|
Thanks Daniel, I agree we want to make sure this sink feature is well described. I like your suggestions and updated this PR accordingly. |
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. I'm pretty happy with this, at least as a first pass (before we get composition and such). Thank you!
This is a feature that is a sink for all the basic JavaScript language features for which I believe we don't want to create separate features. They are all "baseline highest" meaning that baseline_low_date is always 2015-07-29 and baseline_high_date is always 2018-01-29 (the earliest possible dates currently).