-
Notifications
You must be signed in to change notification settings - Fork 199
SVG core feature #1927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG core feature #1927
Conversation
|
Do you plan break this up into smaller features or leave as one big one? |
My plan is to leave as one big one, and as the need arises, break off smaller pieces. For instance, if SVG starts getting attention from implementers and new features start getting added, we may want to split things out. |
|
I couldn't figure out why there was no headline status in |
I had |
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two suggestions here. Provisionally approved, though another round of review might be needed depending on your take on my question about a caniuse correspondence.
features/svg.yml
Outdated
| - svg.elements.feBlend | ||
| - svg.elements.feBlend.in | ||
| - svg.elements.feBlend.in2 | ||
| - svg.elements.feBlend.mode | ||
| - svg.elements.feColorMatrix | ||
| - svg.elements.feColorMatrix.in | ||
| - svg.elements.feColorMatrix.type | ||
| - svg.elements.feColorMatrix.values | ||
| - svg.elements.feComponentTransfer | ||
| - svg.elements.feComponentTransfer.in | ||
| - svg.elements.feComposite | ||
| - svg.elements.feComposite.in | ||
| - svg.elements.feComposite.in2 | ||
| - svg.elements.feComposite.k1 | ||
| - svg.elements.feComposite.k2 | ||
| - svg.elements.feComposite.k3 | ||
| - svg.elements.feComposite.k4 | ||
| - svg.elements.feComposite.operator | ||
| - svg.elements.feComposite.operator.lighter_value | ||
| - svg.elements.feConvolveMatrix | ||
| - svg.elements.feConvolveMatrix.bias | ||
| - svg.elements.feConvolveMatrix.divisor | ||
| - svg.elements.feConvolveMatrix.edgeMode | ||
| - svg.elements.feConvolveMatrix.in | ||
| - svg.elements.feConvolveMatrix.kernelMatrix | ||
| - svg.elements.feConvolveMatrix.kernelUnitLength | ||
| - svg.elements.feConvolveMatrix.order | ||
| - svg.elements.feConvolveMatrix.preserveAlpha | ||
| - svg.elements.feConvolveMatrix.targetX | ||
| - svg.elements.feConvolveMatrix.targetY | ||
| - svg.elements.feDiffuseLighting | ||
| - svg.elements.feDiffuseLighting.diffuseConstant | ||
| - svg.elements.feDiffuseLighting.in | ||
| - svg.elements.feDiffuseLighting.kernelUnitLength | ||
| - svg.elements.feDiffuseLighting.surfaceScale | ||
| - svg.elements.feDisplacementMap | ||
| - svg.elements.feDisplacementMap.in | ||
| - svg.elements.feDisplacementMap.in2 | ||
| - svg.elements.feDisplacementMap.scale | ||
| - svg.elements.feDisplacementMap.xChannelSelector | ||
| - svg.elements.feDisplacementMap.yChannelSelector | ||
| - svg.elements.feDistantLight | ||
| - svg.elements.feDistantLight.azimuth | ||
| - svg.elements.feDistantLight.elevation | ||
| - svg.elements.feDropShadow | ||
| - svg.elements.feDropShadow.dx | ||
| - svg.elements.feDropShadow.dy | ||
| - svg.elements.feDropShadow.in | ||
| - svg.elements.feDropShadow.stdDeviation | ||
| - svg.elements.feFlood | ||
| - svg.elements.feFlood.flood-color | ||
| - svg.elements.feFlood.flood-opacity | ||
| - svg.elements.feFuncA | ||
| - svg.elements.feFuncB | ||
| - svg.elements.feFuncG | ||
| - svg.elements.feFuncR | ||
| - svg.elements.feGaussianBlur | ||
| - svg.elements.feGaussianBlur.in | ||
| - svg.elements.feGaussianBlur.stdDeviation | ||
| - svg.elements.feImage | ||
| - svg.elements.feImage.href | ||
| - svg.elements.feImage.preserveAspectRatio | ||
| - svg.elements.feMerge | ||
| - svg.elements.feMergeNode | ||
| - svg.elements.feMergeNode.in | ||
| - svg.elements.feMorphology | ||
| - svg.elements.feMorphology.in | ||
| - svg.elements.feMorphology.operator | ||
| - svg.elements.feMorphology.radius | ||
| - svg.elements.feOffset | ||
| - svg.elements.feOffset.dx | ||
| - svg.elements.feOffset.dy | ||
| - svg.elements.feOffset.in | ||
| - svg.elements.fePointLight | ||
| - svg.elements.fePointLight.x | ||
| - svg.elements.fePointLight.y | ||
| - svg.elements.fePointLight.z | ||
| - svg.elements.feSpecularLighting | ||
| - svg.elements.feSpecularLighting.in | ||
| - svg.elements.feSpecularLighting.specularConstant | ||
| - svg.elements.feSpecularLighting.specularExponent | ||
| - svg.elements.feSpecularLighting.surfaceScale | ||
| - svg.elements.feSpotLight | ||
| - svg.elements.feSpotLight.limitingConeAngle | ||
| - svg.elements.feSpotLight.pointsAtX | ||
| - svg.elements.feSpotLight.pointsAtY | ||
| - svg.elements.feSpotLight.pointsAtZ | ||
| - svg.elements.feSpotLight.specularExponent | ||
| - svg.elements.feSpotLight.x | ||
| - svg.elements.feSpotLight.y | ||
| - svg.elements.feSpotLight.z | ||
| - svg.elements.feTile | ||
| - svg.elements.feTile.in | ||
| - svg.elements.feTurbulence | ||
| - svg.elements.feTurbulence.baseFrequency | ||
| - svg.elements.feTurbulence.numOctaves | ||
| - svg.elements.feTurbulence.seed | ||
| - svg.elements.feTurbulence.stitchTiles | ||
| - svg.elements.feTurbulence.type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caniuse has a feature SVG filters https://caniuse.com/svg-filters (these lines plus the corresponding API stuff above).
It's a fairly old feature on caniuse (it was added no later than 2012), so if you think it's sufficiently historic to ignore for now that's fine, but I wanted to raise the possibility now, just in case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea, and seeing as it comprises 1/3rd of the keys, it seems like a reasonable split.
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go! 🚀
This adds an SVG catchall. It started similar to the JavaScript initial support feature- #1670, but ended up being most of the feature set, as SVG has not had much active implementation recently. The spec leads the implementation significantly, which has led to lots of partial implementation.
I also added well as a
context-fill-strokefor the only newish feature that seemed to warrant a feature.I also added a draft with ~175 SVG-related keys that are deprecated.