Skip to content

Conversation

@ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Aug 28, 2024

Working with these is a bit annoying. I can never remember the steps needed to handle merging with main. I ended up making a few changes to the workflow file to try to make this more approachable. Changes include:

  • Running dist as part of npm run update-drafts. This is the single biggest headache I was having.
  • Explicitly deleting and adding files, so it's clearer what files this workflow is meant to update.
  • Using a label to identify generated PRs (this will make it easier for me to review these PRs alongside dependabot changes).
  • Using the peter-evans/create-pull-request to do the commit, instead of a custom step and committer config.
  • Linking to the workflow file from the pull request body.

@ddbeck ddbeck added the tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings label Aug 28, 2024
Copy link
Collaborator

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to test but the reasoning sounds good to me. One optional comment.

Co-authored-by: Florian Scholz <fs@florianscholz.com>
@ddbeck
Copy link
Collaborator Author

ddbeck commented Sep 5, 2024

OK, we'll find out how much I broke this on Monday. 😅

@ddbeck ddbeck merged commit 5c0b4c7 into web-platform-dx:main Sep 5, 2024
@ddbeck ddbeck deleted the drafts-worklfow branch September 5, 2024 12:43
@ddbeck
Copy link
Collaborator Author

ddbeck commented Sep 5, 2024

I found the first problem even sooner. #1735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants