Skip to content

Conversation

@ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Sep 16, 2024

update-drafts ought to clean up specs that are finished—that is, specs that have no more keys to assign to features. This PR fixes that deficiency.

Although a change made in #1694 satisfies this, it counteracts the benefit of #1742, which was to avoid needless diffs (see #1782 for an example).

@ddbeck ddbeck added the tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings label Sep 16, 2024
Copy link
Collaborator

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this and re-run #1782 to see if we're good now

@Elchi3 Elchi3 merged commit 473a2bd into web-platform-dx:main Sep 18, 2024
@ddbeck ddbeck deleted the fix-drafts-update branch September 18, 2024 10:56
@ddbeck
Copy link
Collaborator Author

ddbeck commented Sep 18, 2024

@Elchi3 Thank you! I ended up doing the PR from scratch in #1796. This worked really well and I think I may up the frequency for these updates as a result.

ddbeck added a commit to ddbeck/web-features that referenced this pull request Sep 19, 2024
With the lighter-weight diffs introduced in
web-platform-dx#1783 it now makes
sense to run this more frequently, so contributors are less likely to
see already-assigned keys.
Elchi3 pushed a commit that referenced this pull request Oct 7, 2024
With the lighter-weight diffs introduced in
#1783 it now makes
sense to run this more frequently, so contributors are less likely to
see already-assigned keys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants