update-drafts script: don't make date-only modifications
#1742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddbeck
force-pushed
the
no-date-only-spec-draft-updates
branch
5 times, most recently
from
1434921 to
862af60
Compare
This skips writing changes to draft features when the only change is the `draft_date` value. This prevents needlessly large diffs when updating these files and makes it possible to find out which areas we've touched least-recently. Fixes web-platform-dx#1716
ddbeck
force-pushed
the
no-date-only-spec-draft-updates
branch
from
862af60 to
7780216
Compare
autonome
approved these changes
Sep 10, 2024
Contributor
autonome
left a comment
autonome
left a comment
There was a problem hiding this comment.
looks good to me, just a note on some inline docs that'd be helpful to future readers
| changes.length === 1 && !changes[0].added && !changes[0].removed; | ||
| const onlyDateChanges = | ||
| !noChanges && | ||
| changes.length === 3 && |
Contributor
There was a problem hiding this comment.
document the magic 1 and 3 numbers above
Collaborator
Author
There was a problem hiding this comment.
Good idea! I won't even remember that in a week. 😅 Fixed with 13e94db.
ddbeck
added
the
tools and infrastructure
Elchi3
approved these changes
Sep 12, 2024
Collaborator
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
Works as expected for me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #1679, then a rebase is needed.This skips writing changes to draft features when the only change is the
draft_datevalue. This prevents needlessly large diffs when updating these files and makes it possible to find out which areas we've touched least recently.Fixes #1716.