Skip to content

Conversation

@queengooborg
Copy link
Contributor

This PR removes the compat_features value from the features that have already had the BCD features list migrated to BCD tags.

Note: a number of features had comments about new BCD features to add after issues were resolved or nonreal values were removed. The comments have either been preserved or removed as needed, and updates to BCD have been performed as needed.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Sep 20, 2024
@ddbeck
Copy link
Collaborator

ddbeck commented Sep 20, 2024

Did you do this by hand? 😬 I'm not super excited about doing this outside the context of #1672 since we'll be dumping a lot of rich trial cases for that kind of automation. We'll need to do this on a rolling basis (and I believe this is in you and @Elchi3's remit right now).

@queengooborg
Copy link
Contributor Author

queengooborg commented Sep 20, 2024

My thought process is to tackle the bulk by hand to start, so that by the time the automated process is ready to use, a lot less changes will be made at once which will let us catch any issues with the automatic process much easier. So, yes, this PR was done by hand, but I plan to work on automating this in the near future (probably will start after W3C TPAC)!

Doing it manually this first pass did help uncover a few issues that needed to be resolved, such as #1818, which an automated linter couldn't have resolved! 😆

@Elchi3
Copy link
Collaborator

Elchi3 commented Nov 5, 2024

Daniel and I discussed this today and we think it would be good to have a PR that is fully scripted and that stops if it encounters comments or other issues.

@queengooborg can you redo this for just the automated changes?

@Elchi3
Copy link
Collaborator

Elchi3 commented Nov 22, 2024

No answer. Closing.

@Elchi3 Elchi3 closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants