Add VTTCue settings feature #1818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
Elchi3
changed the title
Collaborator
|
I opened #2310 to deal with the constructor |
autonome
suggested changes
Nov 22, 2024
Contributor
autonome
left a comment
autonome
left a comment
There was a problem hiding this comment.
Suggested couple of fixes, but looks good otherwise w/ these addressed!
Co-authored-by: Dietrich Ayala <50103+autonome@users.noreply.github.com>
Collaborator
|
Should this feature also include |
Collaborator
Added along with a compute_from. |
autonome
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates two new features for the WebVTT API. These two features were originally suggested as comments in the
webvttfeature, so this PR does just that!