Error on deprecated compat keys #2210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until we have a representation for discouraged features, we should treat using deprecated BCD keys as an error. This also silences the compat key tag warning, which isn't very useful right now.
github-actions
bot
added
the
tools and infrastructure
jamesnw
approved these changes
Nov 12, 2024
Elchi3
reviewed
Nov 13, 2024
Collaborator
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
I think the deprecated key in ink.yml should probably be removed until we have a way to say on a per key level: "this key belongs to this feature but it is discouraged and should never be considered baseline or be part of baseline calculations"?
For svg-deprecated.yml, I guess we are also blocked there on marking entire features as deprecated/discouraged?
Otherwise this LGTM
Collaborator
Author
|
OK, I've changed this slightly to warn for drafts, but error for published features. This means that changing |
Collaborator
Author
|
Also, note that this is not a complete resolution. We might still have other problematic keys. See #1894 |
Collaborator
Author
|
And we've now got #2227 to fix ink itself. |
Elchi3
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we have a representation for discouraged features, we should treat using deprecated BCD keys as an error.
This also silences the compat key tag warning, which isn't very useful right now.