Skip to content

Error on deprecated compat keys #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Error on deprecated compat keys #2210

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3d9c87
Error on deprecated compat keys
ddbeck Nov 12, 2024
750b44f
Merge branch 'main' into silence-compat-tag-warning
Elchi3 Nov 13, 2024
b259b5b
Warn for drafts; error for published features
ddbeck Nov 13, 2024
250ff8a
Merge branch 'main' into silence-compat-tag-warning
Elchi3 Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions scripts/dist.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ function toDist(sourcePath: string): YAML.Document {
if (source.compat_features) {
source.compat_features.sort();
if (isDeepStrictEqual(source.compat_features, taggedCompatFeatures)) {
logger.warn(
logger.silly(
`${id}: compat_features override matches tags in @mdn/browser-compat-data. Consider deleting the compat_features override.`,
);
}
Expand Down Expand Up @@ -234,9 +234,18 @@ function toDist(sourcePath: string): YAML.Document {
});

if (computedStatus.discouraged) {
logger.warn(
`${id}: contains at least one deprecated compat feature and can never be Baseline. Was this intentional?`,
);
const isDraft: boolean = source.draft_date ?? false;

if (!source.draft_date) {
logger.error(
`${id}: contains at least one deprecated compat feature and can never be Baseline. This is forbidden for published features.`,
);
exitStatus = 1;
} else {
logger.warn(
`${id}: draft contains at least one deprecated compat feature and can never be Baseline. Was this intentional?`,
);
}
}

computedStatus = JSON.parse(computedStatus.toJSON());
Expand Down