Skip to content

Conversation

@captainbrosset
Copy link
Contributor

Fixes #2738.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Mar 15, 2025
@captainbrosset
Copy link
Contributor Author

Thanks @lukewarlow. I've addressed your comment about the description.

Copy link
Collaborator

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(See #2738 for a discussion why closedBy is not part of this)

@Elchi3 Elchi3 merged commit 00f15c1 into main Mar 31, 2025
3 checks passed
@Elchi3 Elchi3 deleted the request-close branch March 31, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dialog.requestClose()

4 participants