Skip to content

New dialog.requestClose() feature #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 31, 2025
Merged

New dialog.requestClose() feature #2775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45725d7
new dialog.requestClose() feature
captainbrosset Mar 15, 2025
55caeb9
Merge branch 'main' into request-close
captainbrosset Mar 20, 2025
be8846f
Addressed review comments
captainbrosset Mar 20, 2025
1f4ab76
Merge branch 'main' into request-close
captainbrosset Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions features/requestclose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
name: dialog.requestClose()
description: The `requestClose()` method of a `<dialog>` HTML element closes the dialog, firing a `cancel` event first, which listeners can use to prevent the dialog from closing. This differs from the `close()` method, which only fires the non-cancelable `close` event.
spec: https://html.spec.whatwg.org/multipage/interactive-elements.html#dom-dialog-requestclose
group: html-elements
compat_features:
- api.HTMLDialogElement.requestClose
11 changes: 11 additions & 0 deletions features/requestclose.yml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Generated from: requestclose.yml
# Do not edit this file by hand. Edit the source file instead!

status:
baseline: false
support:
chrome: "134"
chrome_android: "134"
edge: "134"
compat_features:
- api.HTMLDialogElement.requestClose