[Gecko Bug 1537554] part3 : do not collect negative length cue for other cues.#16152
Merged
moz-wptsync-bot merged 1 commit intomasterfrom Apr 3, 2019
Merged
[Gecko Bug 1537554] part3 : do not collect negative length cue for other cues.#16152moz-wptsync-bot merged 1 commit intomasterfrom
moz-wptsync-bot merged 1 commit intomasterfrom
Conversation
Cue might have negative length because user can set cue's end time via `TextTrackCue`'s API and the spec doesn't have strong restriction that the end time should be equal or larger than the start time of the cue. As the negative length cue won't be displayed, we have no need to add it to the `other cues`. [1] https://html.spec.whatwg.org/multipage/media.html#dom-texttrackcue-endtime Differential Revision: https://phabricator.services.mozilla.com/D24857 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1537554 gecko-commit: c49d99af4cadaeaac4e8f3f3c3247698e3dca583 gecko-integration-branch: central gecko-reviewers: jya
wpt-pr-bot
approved these changes
Mar 29, 2019
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
Already reviewed downstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cue might have negative length because user can set cue's end time via
TextTrackCue's API and the spec doesn't have strong restriction that the end time should be equal or larger than the start time of the cue.As the negative length cue won't be displayed, we have no need to add it to the
other cues.[1] https://html.spec.whatwg.org/multipage/media.html#dom-texttrackcue-endtime
Differential Revision: https://phabricator.services.mozilla.com/D24857
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1537554
gecko-commit: c49d99af4cadaeaac4e8f3f3c3247698e3dca583
gecko-integration-branch: central
gecko-reviewers: jya