[docs] Correct minor problems#17751
Merged
Merged
Conversation
sideshowbarker
approved these changes
Jul 10, 2019
| filler text. | ||
|
|
||
| Obviously, none of this can be taken as absolute rules, as testing of | ||
| None of these rules are absolute because testing |
Member
There was a problem hiding this comment.
Suggested change
| None of these rules are absolute because testing | |
| None of these rules are absolute, because testing |
Contributor
Author
There was a problem hiding this comment.
This looks like a stylistic usage rather than one that clarifies meaning. I'd prefer to omit it unless you have a more objective rational.
Previously, the description of test file formats was incomplete and somewhat confusingly-worded. Expand the explanation to fully describe the accepted formats, and include additional advice for how to learn more in context.
This section is also included in the "General Guidelines" document which describes expecations for all tests, including "rendering tests."
The word "obviously" may discourage readers for whom the following statement was not obvious. Remove it and simplify the sentence structure.
Contributor
Author
|
gh-17797 introduced a trivial conflict for this change set. I've rebased and force-pushed the result to this branch. The original version of this branch is available here: master...bocoup:docs-misc-orig I'm going to merge this myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes aren't strongly related to each other, but submitting separate
pull requests seemed a little too process-heavy. That said, I'm happy to split
this apart if any specific changes warrant a dedicated discussion.