webrtc wpt: add test for setParameters active=false w/simulcast#23924
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Jun 3, 2020
Merged
webrtc wpt: add test for setParameters active=false w/simulcast#23924chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
Jun 2, 2020
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2225774
branch
from
a8b782f to
4a089e2
Compare
adds a test that verifies setting active to false on all three layers stops sending frames. Ref w3c/webrtc-pc#2470 BUG=None Change-Id: Ic6bf346085af98cce13c90e141f83224e57069d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225774 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#774521}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2225774
branch
from
4a089e2 to
3158eb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a test that verifies setting active to false on all three
layers stops sending frames.
Ref w3c/webrtc-pc#2470
BUG=None
Change-Id: Ic6bf346085af98cce13c90e141f83224e57069d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225774
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774521}