[css-pseudo] Add expectation for marker-list-style-position.html WPT#24315
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Jun 24, 2020
Merged
[css-pseudo] Add expectation for marker-list-style-position.html WPT#24315chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
Jun 23, 2020
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Loirooriol
force-pushed
the
chromium-export-cl-2260618
branch
from
ce8859b to
84713f1
Compare
The marker-list-style-position.html WPT test was created by Mozilla, and it relies on inside list markers being affected by ::first-line. However, that doesn't happen in Chromium and WebKit, and the relevant issue (w3c/csswg-drafts#4506) is still open. Therefore I'm adding a 2nd expectation in order to allow both behaviors. Bug: 457718 Change-Id: Id61fbdd07940d541eb7a9638a0fc1aefc13bb545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260618 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#781817}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2260618
branch
from
84713f1 to
6db662c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The marker-list-style-position.html WPT test was created by Mozilla, and
it relies on inside list markers being affected by ::first-line.
However, that doesn't happen in Chromium and WebKit, and the relevant
issue (w3c/csswg-drafts#4506) is still open.
Therefore I'm adding a 2nd expectation in order to allow both behaviors.
Bug: 457718
Change-Id: Id61fbdd07940d541eb7a9638a0fc1aefc13bb545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260618
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#781817}