Don't adjust computed value for position:sticky#28278
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Mar 30, 2021
Merged
Don't adjust computed value for position:sticky#28278chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
Mar 29, 2021
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
2a97104 to
b07fc32
Compare
b07fc32 to
cd6ea67
Compare
Sticky positioning does not apply to certain table display types, but should only affect the used value, not the computed. Bug: 1192443 Change-Id: Ic6c57d85f07a1d1825964365631cdf4abf206cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2790447 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#867644}
cd6ea67 to
394879d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sticky positioning does not apply to certain table display types, but
should only affect the used value, not the computed.
Bug: 1192443
Change-Id: Ic6c57d85f07a1d1825964365631cdf4abf206cbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2790447
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#867644}