[GridFragmentation] Support basic grid-item fragmentation.#31324
Merged
Conversation
wpt-pr-bot
approved these changes
Oct 20, 2021
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3210245
branch
from
1ada7e5 to
bbbb328
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3210245
branch
2 times, most recently
from
842623d to
f5257c5
Compare
This stores the grid-geometry on the break-token, then iterates over all the grid items to decide which are within the current fragmentainer. If they are within the current fragmentainer, performs layout, and adds them to the container builder. This patch doesn't: - Add OOFs correctly. - Support "growing" grid rows to accommodate the auto min-size of grid-items. - Support break-before (BreakBeforeChildIfNeeded call). - Support variable inline-size fragmentainers. Bug: 614667 Change-Id: Ieea02abc3a5d98e628f9cfa205798cafc6ab7d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3210245 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#933934}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3210245
branch
from
f5257c5 to
e543451
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stores the grid-geometry on the break-token, then iterates over
all the grid items to decide which are within the current fragmentainer.
If they are within the current fragmentainer, performs layout, and adds
them to the container builder.
This patch doesn't:
grid-items.
Bug: 614667
Change-Id: Ieea02abc3a5d98e628f9cfa205798cafc6ab7d66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3210245
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#933934}