Remove deprecated font css flag from css directory files#31991
Conversation
wpt-pr-bot
added
css-counter-styles
css-fonts
css-text
css-ui
CSS2
wg-css
wg-fonts
WOFF2
labels
The wording I would suggest when a single issue will require a lot of PRs is "Part of #23253" or similar. Since patches can be applied ( |
|
This is mechanical, so I'll review 10 files chosen with |
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
I've spot checked 10 files now, left a few comments about odd things. This all seems fine though.
| <link rel="help" href="http://www.w3.org/TR/CSS21/fonts.html#font-family-prop" /> | ||
| <link rel="help" href="http://www.w3.org/TR/css-fonts-3/#font-family-prop"/> | ||
| <meta name="flags" content="font" /> | ||
| <meta name="assert" content="Font family named 'inherit' needs to be quoted to avoid conflict with keyword 'inherit'." /> |
There was a problem hiding this comment.
This is a visual test and isn't run in WPT. There's a PREREQUISITE bit below that points to a font that doesn't exist. But that's fine, it's not more broken after this change.
| <link rel='help' href='http://www.w3.org/TR/css-counter-styles-3/#simple-numeric'> | ||
| <link rel="reviewer" title="Chris Lilley" href="mailto:chris@w3.org" /> | ||
| <meta name='flags' content='font'> | ||
| <meta name="assert" content="list-style-type: armenian produces numbers after 9 items per the spec."> |
There was a problem hiding this comment.
This is a ref, and it's curious that the test itself doesn't have the font flag. But anyway, the test passes everywhere, there's nothing to see here:
https://wpt.fyi/results/css/css-counter-styles/armenian/css3-counter-styles-007.html?label=experimental&label=master&aligned
4 participants
Part of #23253
removes all instances of the
fontcss flag that appears in any file in thecssdirectory of this repo, as it is no longer a valid requirements flag. Valid flags can be found here.