Miss the cache on nested multicol with OOF.#32944
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Feb 22, 2022
Merged
Miss the cache on nested multicol with OOF.#32944chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
Feb 22, 2022
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
We handle OOFs that are contained by a multicol in a nested fragmentation context in a special way: We'll lay them out when we have returned to the outermost fragmentation context root (that's when we know how many inner fragmentainers we've got). If we both do this, and hit the cache, and thus keep and re-use the old OOF fragments along with the rest, we'll end up with extraneous fragments when we return to the outermost fragmentation context root and add fragments for them there as well. Bug: 1296900 Change-Id: I78193353092529e3bd11d58785afa8e4d1f19ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3481336 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#973852}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3481336
branch
from
c0f25a9 to
35f9f41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We handle OOFs that are contained by a multicol in a nested
fragmentation context in a special way: We'll lay them out when we have
returned to the outermost fragmentation context root (that's when we
know how many inner fragmentainers we've got). If we both do this, and
hit the cache, and thus keep and re-use the old OOF fragments along with
the rest, we'll end up with extraneous fragments when we return to the
outermost fragmentation context root and add fragments for them there as
well.
Bug: 1296900
Change-Id: I78193353092529e3bd11d58785afa8e4d1f19ebb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3481336
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#973852}