[renderblocking] Implement render-blocking on script elements#33145
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Mar 10, 2022
Merged
[renderblocking] Implement render-blocking on script elements#33145chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
Mar 9, 2022
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3511116
branch
from
2065367 to
efcf085
Compare
This patch makes RenderBlockingResourceManager to accept scripts as render-blocking resources, and implements the following parts of the spec: 1. Right before fetching a render-blocking script, add it to RenderBlockingResourceManager: https://html.spec.whatwg.org/multipage/scripting.html#script-processing-model:block-rendering 2. When executing a script, remove it from RenderBlockingResourceManager https://html.spec.whatwg.org/multipage/scripting.html#script-processing-model:unblock-rendering 3. When a render-blocking script is removed, also remove it from RenderBlockingResourceManager, so that rendering is unblocked even without executing the script: https://html.spec.whatwg.org/multipage/urls-and-fetching.html#blocking-attributes:unblock-rendering Bug: 1271296 Change-Id: Ib5d7391668efb1a0c74a3c152e02c1b533accc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3511116 Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#979904}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3511116
branch
from
efcf085 to
38a59b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes RenderBlockingResourceManager to accept scripts as
render-blocking resources, and implements the following parts of the
spec:
RenderBlockingResourceManager:
https://html.spec.whatwg.org/multipage/scripting.html#script-processing-model:block-rendering
https://html.spec.whatwg.org/multipage/scripting.html#script-processing-model:unblock-rendering
RenderBlockingResourceManager, so that rendering is unblocked even
without executing the script:
https://html.spec.whatwg.org/multipage/urls-and-fetching.html#blocking-attributes:unblock-rendering
Bug: 1271296
Change-Id: Ib5d7391668efb1a0c74a3c152e02c1b533accc43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3511116
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#979904}