feat(streams): detach buffer using structuredClone#36723
Open
marcosc90 wants to merge 1 commit intoweb-platform-tests:masterfrom
Open
feat(streams): detach buffer using structuredClone#36723marcosc90 wants to merge 1 commit intoweb-platform-tests:masterfrom
marcosc90 wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
requested review from
domenic,
ricea,
wanderview,
youennf and
yutakahirano
marcosc90
commented
Oct 28, 2022
| if(typeof postMessage === 'function') { | ||
| postMessage(buffer, '*', [buffer]); | ||
| } else { | ||
| structuredClone(buffer, { transfer: [buffer] }); |
Contributor
Author
There was a problem hiding this comment.
Left postMessage in case there's a platform running this test that doesn't yet support structuredClone
Member
There was a problem hiding this comment.
Can we have a separate test with structuredClone below, and add an assert_implements_optional here so that it can pass in Deno? With the current PR Deno and browsers will have different code paths which wouldn't be ideal.
ricea
approved these changes
Nov 4, 2022
Contributor
There was a problem hiding this comment.
Cool. I wonder if it is worth renaming the file from .window.js to .any.js. This would improve coverage in many browsers, but not all supported structuredClone in workers according to mdn: https://developer.mozilla.org/en-US/docs/Web/API/structuredClone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
structuredCloneas a fallback to detach an ArrayBuffer ifpostMessageis not defined, so the test can be used in Deno