Revert "LoAF: support approximate source locations for promise resolvers"#41596
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Aug 23, 2023
Merged
Revert "LoAF: support approximate source locations for promise resolvers"#41596chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
Aug 23, 2023
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
…ers" This reverts commit 07a41b1a0d49acd929ba716332c65ec7c8c55a2b. Reason for revert: performance regression. See https://bugs.chromium.org/p/chromium/issues/detail?id=1475117 Will try to refactor and run pinpoint on the CL with that test. Original change's description: > LoAF: support approximate source locations for promise resolvers > > Attribute the source location of a promise resolver that contributed > to LoAF to the script that created it, e.g. the script that called > fetch(). > > Getting the exact source location of the promise resolver itself > would require capturing a stack trace, which might be too much > overhead, so this is the next best thing. We can revise in the future > whether a shallow stack trace is something we're OK with in some > circumstances. > > Note that it's impossible to get the location of the actual then(), > as that's a microtask that's batched together with all the rest of > the microtasks (e.g. other then()s of the same promise). > > The animation frame monitor maintains a weak map between the promise > resolver and the source location of the event > listener/script-block/callback that was responsible for creating it. > This source location is then used when a promise is resolved and the > resolution task is a long script that contributes to the LoAF. > > Bug: 1392685 > Change-Id: I268ebbbf035b0800a5d1bd61cd939e46533fe064 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4783320 > Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> > Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1186486} Bug: 1392685 Change-Id: I11a4618e5e9be83c116547d63483bae4c8954d13 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4803709 Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/main@{#1187097}
9b24b78 to
a52894a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 07a41b1a0d49acd929ba716332c65ec7c8c55a2b.
Reason for revert: performance regression.
See https://bugs.chromium.org/p/chromium/issues/detail?id=1475117
Will try to refactor and run pinpoint on the CL with that test.
Original change's description:
Bug: 1392685
Change-Id: I11a4618e5e9be83c116547d63483bae4c8954d13
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4803709
Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1187097}