[css-anchor-position] Style contain anchor-name #44226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL implements style containment for anchor-as 'scoped to a sub- tree' as defined in the css-contain-2 spec[1]. Tests are made tentative as this is currently a CSSWG resolution, not in any spec yet. We now need to store all in-flow candidate anchors, not only out-of- flow ones, because the selected anchor depends on whether the querying element is in the same contain:style subtree or not. [1] https://drafts.csswg.org/css-contain-2/#property-scoped -to-a-sub-tree [2] w3c/csswg-drafts#9100 Bug: 1518526 Change-Id: I745245eb22ccb4af7aa5cfd814af2955077085b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237173 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1253236}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5237173
branch
from
419ec36 to
2f5e2f2
Compare
wpt-pr-bot
approved these changes
Jan 29, 2024
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL implements style containment for anchor-as 'scoped to a sub-
tree' as defined in the css-contain-2 spec[1]. Tests are made tentative
as this is currently a CSSWG resolution, not in any spec yet.
We now need to store all in-flow candidate anchors, not only out-of-
flow ones, because the selected anchor depends on whether the querying
element is in the same contain:style subtree or not.
[1] https://drafts.csswg.org/css-contain-2/#property-scoped
-to-a-sub-tree
[2] w3c/csswg-drafts#9100
Bug: 1518526
Change-Id: I745245eb22ccb4af7aa5cfd814af2955077085b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237173
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1253236}