Add test for unknown, invalid ancillary chunk which should be error corrected per spec. #44836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PNG spec requires that errors in unknown ancillary chunks are not fatal errors and are recovered. This test exercises this, for non-animated PNG.
The test image has a malformed chunk (actually an
sBITchunk with the second byte changed to ASCII control codeSOH(0x01). This makes the chunk unknown, and as it is ancillary it can be ignored.The reference has a copy of the test image with the invalid chunk removed.
This test was requested (by @annevk) in the course of
because there is browser non-interop. Chrome renders the image, while Firefox throws an error, although this is currently being changed in the FF 125 time frame.