[layout] Support min-block-size/max-block-size min-content/etc in flex#47367
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Jul 30, 2024
Merged
[layout] Support min-block-size/max-block-size min-content/etc in flex#47367chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
This patch adds support for things like "max-height: min-content" within the flex sizing algorithm. We introduce variants of ResolveMinBlockLength/etc which accept a function-ref to resolve min-content/etc when required. We somewhat supported this previously (see previous logic in ShouldApplyMinSizeAutoForChild), but it wasn't complete. Bug: 40151761 Change-Id: Ib9f70e70d73732e3694598653d6517619e561454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5744698 Reviewed-by: David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1335087}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5744698
branch
from
88cffa8 to
ce8ed69
Compare
wpt-pr-bot
approved these changes
Jul 30, 2024
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for things like "max-height: min-content"
within the flex sizing algorithm.
We introduce variants of ResolveMinBlockLength/etc which accept a
function-ref to resolve min-content/etc when required.
We somewhat supported this previously (see previous logic in
ShouldApplyMinSizeAutoForChild), but it wasn't complete.
Bug: 40151761
Change-Id: Ib9f70e70d73732e3694598653d6517619e561454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5744698
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1335087}