Skip to content

Update WEB_FEATURES.yml for document-caretpositionfrompoint and file-system-access#51310

Merged
nairnandu merged 10 commits intoweb-platform-tests:masterfrom
nairnandu:master
Mar 24, 2025
Merged

Update WEB_FEATURES.yml for document-caretpositionfrompoint and file-system-access#51310
nairnandu merged 10 commits intoweb-platform-tests:masterfrom
nairnandu:master

Conversation

@nairnandu
Copy link
Contributor

No description provided.

@wpt-pr-bot wpt-pr-bot added the fs label Mar 13, 2025
@nairnandu
Copy link
Contributor Author

Adding WEB_FEATURES.yml for file-system-access as well

@nairnandu nairnandu changed the title Update WEB_FEATURES.yml for document-caretpositionfrompoint Update WEB_FEATURES.yml for document-caretpositionfrompoint and file-system-access Mar 13, 2025
Copy link
Contributor

@jcscottiii jcscottiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes to self:

css/cssom and shadow-dom have no conflicts with existing rules.

document-caretpositionfrompoint and file-system-access match up with the IDs from the web features repo

- https://github.com/web-platform-dx/web-features/blob/main/features/document-caretpositionfrompoint.yml 
- https://github.com/web-platform-dx/web-features/blob/main/features/file-system-access.yml

LGTM!

Copy link
Contributor

@fergald fergald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for file-system-access

Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from fs/WEB_FEATURES.yml

@nairnandu nairnandu merged commit d6e0cdd into web-platform-tests:master Mar 24, 2025
18 checks passed
mohamedamir pushed a commit to mohamedamir/wpt that referenced this pull request Mar 27, 2025
…system-access (web-platform-tests#51310)

* Update WEB_FEATURES.yml for document-caretpositionfrompoint

* Update WEB_FEATURES.yml for document-caretpositionfrompoint

* Create WEB_FEATURES.yml for file-system-access web feature

* Create WEB_FEATURES.yml for file-system-access web feature

* Delete fs/WEB_FEATURES.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments