Use ConsumeNumber() for flex shorthand #51665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6404314
branch
from
db5fe91 to
1008051
Compare
Remove use of ConsumeNumberRaw_DO_NO_USE which does not handle calc()- expressions. Bug: 405311304 Change-Id: I2a7ed41592239d43428eaf8dc8663d6c0d956710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6404314 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Daniil Sakhapov <sakhapov@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1439301}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6404314
branch
from
1008051 to
d7170d6
Compare
wpt-pr-bot
approved these changes
Mar 28, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of ConsumeNumberRaw_DO_NO_USE which does not handle calc()-
expressions.
Bug: 405311304
Change-Id: I2a7ed41592239d43428eaf8dc8663d6c0d956710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6404314
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Daniil Sakhapov <sakhapov@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439301}