Disallow calc() in named timeline range keyframe selectors #52109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pure percentage selectors already disallowed calc() expressions. The named selectors should not be different. It is not obvious from the spec that this should be the behavior, but having selectors with calc() that contains relative lengths or sibling-index() would have to be dropped regardlessly. Bug: 410883045 Change-Id: I56e0c57f9cdaae9490b47844dad9e06fde09c214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6476968 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Daniil Sakhapov <sakhapov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1450184}
wpt-pr-bot
approved these changes
Apr 22, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure percentage selectors already disallowed calc() expressions. The
named selectors should not be different. It is not obvious from the spec
that this should be the behavior, but having selectors with calc() that
contains relative lengths or sibling-index() would have to be dropped
regardlessly.
Bug: 410883045
Change-Id: I56e0c57f9cdaae9490b47844dad9e06fde09c214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6476968
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Daniil Sakhapov <sakhapov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1450184}