[Gecko Bug 1959610] Align CloseOuter with #script-closable session history check. #52115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since whatwg/html#6315, script-closable checks for a history length of one, instead of the session history containing only one document. This commit also adds a wpt to test that windows opened by links and forms count as `created by a script`. Differential Revision: https://phabricator.services.mozilla.com/D245035 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1959610 gecko-commit: e0390012bdc423f35439ff7c3709ba26982b8883 gecko-reviewers: smaug
wpt-pr-bot
approved these changes
Apr 22, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since whatwg/html#6315, script-closable checks for a
history length of one, instead of the session history containing only one
document.
This commit also adds a wpt to test that windows opened by links and forms
count as
created by a script.Differential Revision: https://phabricator.services.mozilla.com/D245035
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1959610
gecko-commit: e0390012bdc423f35439ff7c3709ba26982b8883
gecko-reviewers: smaug