Implement logic to pause/resume depth sensing #52121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `(pause|resume)depthSensing` methods/behavior from the spec to allow sites to mitigate the impact of having the depth sensing feature enabled when they don't need depth (e.g. maybe they only need depth for a placement scenario and are okay to not receive that data at other times). Note to Gardeners: This test relies on WebGL, which is known to not work on the arm64 WPTs. While I've attempted to update the baselines, please prefer to simply disable any of the WPTs in this CL on arm64 if any end up missed. Bug: 410607163 Change-Id: Id11ac7cf33dd2a310f58701b5c425b170d5446d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6470945 Reviewed-by: Elly FJ <ellyjones@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Fred Shih <ffred@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#1450623}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6470945
branch
from
252f09b to
3165b4b
Compare
wpt-pr-bot
approved these changes
Apr 23, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
(pause|resume)depthSensingmethods/behavior from the spec toallow sites to mitigate the impact of having the depth sensing feature
enabled when they don't need depth (e.g. maybe they only need depth for
a placement scenario and are okay to not receive that data at other
times).
Note to Gardeners: This test relies on WebGL, which is known to not
work on the arm64 WPTs. While I've attempted to update the baselines,
please prefer to simply disable any of the WPTs in this CL on arm64 if
any end up missed.
Bug: 410607163
Change-Id: Id11ac7cf33dd2a310f58701b5c425b170d5446d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6470945
Reviewed-by: Elly FJ <ellyjones@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Fred Shih <ffred@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1450623}