Fix customizable select keyboard navigation hang #52177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes an infinite loop when using the arrow keys to keyboard navigate backwards over an <hr> element. The bug only occurs when the select is opted into customizable select with appearance:base-select. Fixed: 412578717 Change-Id: Ib665e56ddbd4b230194f393f559df82f5b41ba7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6484650 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Di Zhang <dizhangg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1451850}
wpt-pr-bot
approved these changes
Apr 25, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6484650
branch
from
6e56841 to
f56acc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an infinite loop when using the arrow keys to keyboard
navigate backwards over an <hr> element. The bug only occurs when the
select is opted into customizable select with appearance:base-select.
Fixed: 412578717
Change-Id: Ib665e56ddbd4b230194f393f559df82f5b41ba7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6484650
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1451850}