[reading-flow] Can render with carousel #52179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6479432
branch
2 times, most recently
from
016ec7c to
33022a2
Compare
Setting CSS property reading-flow on a carousel scroller is failing DCHECKs for both the focus navigation and the accessibility tree. To fix this use case, 1. Relax the OwnedByReadingFlow to be element instead of HTMLElement. This is because pseudo-element can be reading flow item scope owners. 2. Change Element::ReadingFlowChildren to add out of flow reading flow items in LayoutTreeBuilderTraversal instead of FlatTreeTraversal. This will add scroll marker and related pseudo elements. Change-Id: Icbb523c4f93aff316a8f8bfcbf867e1ec781a1d7 Bug: 398280418, 412401428, 413659838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6479432 Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Di Zhang <dizhangg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1451922}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6479432
branch
from
33022a2 to
cce0d40
Compare
wpt-pr-bot
approved these changes
Apr 25, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting CSS property reading-flow on a carousel scroller is failing
DCHECKs for both the focus navigation and the accessibility tree. To
fix this use case,
This is because pseudo-element can be reading flow item scope owners.
items in LayoutTreeBuilderTraversal instead of FlatTreeTraversal.
This will add scroll marker and related pseudo elements.
Change-Id: Icbb523c4f93aff316a8f8bfcbf867e1ec781a1d7
Bug: 398280418, 412401428, 413659838
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6479432
Reviewed-by: Mason Freed <masonf@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1451922}