Further break up popover-focus-2.html #52187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is quite slow. This CL uses variants to break it up into individual tests, each of which takes about 1/3 of the total time. Hopefully that speeds it up enough to stop timing out on the bots. Locally, on my Mac, using headless the original test takes about 22 seconds. The new set of tests each seem to take about 7 seconds, which should hopefully be fast enough to avoid timeouts. Note my comment here: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/TestLists/content_shell.filter;l=900;drc=60e02302b92e7570aec39eb441c16caa7c605a0b This test takes a *huge* amount of time on headless for some reason. On content shell, instead of 22 seconds, it takes 6 locally. Fixed: 408782594 Change-Id: Iaf184a7b36b845af64e7a31e8c148271f490c10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6491141 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1452106}
wpt-pr-bot
approved these changes
Apr 25, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is quite slow. This CL uses variants to break it up into
individual tests, each of which takes about 1/3 of the total time.
Hopefully that speeds it up enough to stop timing out on the bots.
Locally, on my Mac, using headless the original test takes about 22
seconds. The new set of tests each seem to take about 7 seconds, which
should hopefully be fast enough to avoid timeouts.
Note my comment here:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/TestLists/content_shell.filter;l=900;drc=60e02302b92e7570aec39eb441c16caa7c605a0b
This test takes a huge amount of time on headless for some reason.
On content shell, instead of 22 seconds, it takes 6 locally.
Fixed: 408782594
Change-Id: Iaf184a7b36b845af64e7a31e8c148271f490c10e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6491141
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1452106}